Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate “Add React to an Existing Project" #665

Merged

Conversation

breadadams
Copy link
Contributor

The translation for "Add React to an Existing Project" (from #500).

Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo se ve muy bien en general, te he dejado un par de comentarios.

Una de ellas es acerca de *framework* a framework. Solo para mantener consistencia con la versión original en Inglés.

src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
src/content/learn/add-react-to-an-existing-project.md Outdated Show resolved Hide resolved
@breadadams
Copy link
Contributor Author

Gracias por el review @mateoguzmana, el "framework" en cursiva lo he sacado del glosario. ¿Quizás lo he interpretado mal?

- Apply suggestions from code review

Co-authored-by: Mateo Guzmán <[email protected]>
Copy link
Contributor Author

@breadadams breadadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se me olvidó publicar estas dudas que tenía sobre mi traducción, son solo un par de puntos que recopilé durante el proceso. Gracias ✌️

@mateoguzmana
Copy link
Collaborator

el "framework" en cursiva lo he sacado del glosario

@breadadams ah, vale! ayudo a clarificar un poco:

En el glosario, las palabras que aparecen en cursiva se utilizan para hacer énfasis en que se mantienen igual que en la traducción original. Por lo tanto, no parece ser necesario aplicar ese formato en el texto en sí.

Y, en tus modificaciones, el término "framework" aparece en negrita.

@breadadams
Copy link
Contributor Author

Gracias por aclararlo @mateoguzmana, eso tiene sentido 😄 . Aplicaré las modificaciones, pero para que quede claro aparecen en cursiva actualmente (un solo *) - lo puedes verificar en el preview: https://es-react-ozf5vs6v4-fbopensource.vercel.app/learn/add-react-to-an-existing-project

+ Apply suggestions from code review

Co-authored-by: Mateo Guzmán <[email protected]>
@mateoguzmana mateoguzmana self-requested a review May 2, 2023 04:52
@carburo
Copy link
Member

carburo commented May 5, 2023

el "framework" en cursiva lo he sacado del glosario

@breadadams ah, vale! ayudo a clarificar un poco:

En el glosario, las palabras que aparecen en cursiva se utilizan para hacer énfasis en que se mantienen igual que en la traducción original. Por lo tanto, no parece ser necesario aplicar ese formato en el texto en sí.

Y, en tus modificaciones, el término "framework" aparece en negrita.

Las cursivas en el glosario sí indican usarlas en el texto. Sin embargo, hasta ahora no se ha sido consistente con esta recomendación. Lo que pienso actualmente es que probablemente sea preferible mantenerlas en redonda si es una palabra de uso común en la terminología técnica. Deberíamos actualizar el glosario para evitar confusiones.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.78 KB (🟡 +8 B) 170.4 KB
/500 76.77 KB (🟡 +8 B) 170.4 KB
/[[...markdownPath]] 78.24 KB (🟡 +8 B) 171.87 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants